Closed
Bug 1414631
Opened 8 years ago
Closed 8 years ago
chromium: Remove the Chromium Process class
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
In file included from /data/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/ipc/chromium/Unified_cpp_ipc_chromium1.cpp:2:
In file included from /data/jenkins/workspace/firefox-clang-last/ipc/chromium/src/base/process_posix.cc:7:
/data/jenkins/workspace/firefox-clang-last/ipc/chromium/src/base/process.h:76:10: error: private field 'last_working_set_size_' is not used [-Werror,-Wunused-private-field]
size_t last_working_set_size_;
^
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Attachment #8925355 -
Flags: review?(mh+mozilla)
|
||
Comment 2•8 years ago
|
||
We can probably delete this entire class. The only use seems to be a static method call at [1], which should be replaceable with GetCurrentProcId().
[1] https://searchfox.org/mozilla-central/rev/5a60492a53667fc61a62af1847d005a210b7a4f6/ipc/glue/GeckoChildProcessHost.cpp#631
| Comment hidden (mozreview-request) |
|
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8925355 [details]
Bug 1414631 - Remove the Chromium Process class
https://reviewboard.mozilla.org/r/196506/#review202526
Attachment #8925355 -
Flags: review?(jld) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/901652a2298b
Remove the Chromium Process class r=jld
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
|
Assignee | |
Updated•8 years ago
|
Summary: chromium: process.h - private field 'last_working_set_size_' is not used → chromium: Remove the Chromium Process class
You need to log in
before you can comment on or make changes to this bug.
Description
•